react-doctor/three-tsl-no-js-uniform-branch
JavaScript branch reads a TSL uniform value
- Category: Bugs
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: three
- Tags: three, webgl
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/three-tsl-no-js-uniform-branch. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
const shader = Fn(() =>
opacity.value > 0.5 ? foreground : background,
);Corrected pattern
const shader = Fn(() =>
opacity.greaterThan(0.5).select(foreground, background),
);How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/three-tsl-no-js-uniform-branch diagnostic in the current repository.
Required change:
- Express uniform-dependent shader control flow with TSL If, select, or Loop nodes so it runs on the GPU.const shader = Fn(() =>
opacity.value > 0.5 ? foreground : background,
);const shader = Fn(() =>
opacity.greaterThan(0.5).select(foreground, background),
);Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
three.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Bugs rules from the rules reference:
react-doctor/three-webgpu-no-legacy-effect-composer: Legacy EffectComposer used with WebGPURendererreact-doctor/three-webgpu-no-legacy-material-api: Legacy material API used with WebGPURendererreact-doctor/valtio-no-proxy-read-in-render: Valtio proxy read during renderreact-doctor/valtio-no-snapshot-in-callback: Valtio snapshot read in a callbackreact-doctor/void-dom-elements-no-children: Remove children from the void element, or use a non-void element if children are needed.