react-doctor/three-shader-require-uniform-bindings
Shader uniform has no material binding
- Category: Bugs
- Severity: error
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: three
- Tags: three, webgl
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/three-shader-require-uniform-bindings. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
const material = new ShaderMaterial({
fragmentShader: `uniform float opacity;`,
uniforms: {},
});Corrected pattern
const material = new ShaderMaterial({
fragmentShader: `uniform float opacity;`,
uniforms: { opacity: { value: 1 } },
});How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/three-shader-require-uniform-bindings diagnostic in the current repository.
Required change:
- Add every custom GLSL uniform to the ShaderMaterial uniforms object with a compatible value.const material = new ShaderMaterial({
fragmentShader: `uniform float opacity;`,
uniforms: {},
});const material = new ShaderMaterial({
fragmentShader: `uniform float opacity;`,
uniforms: { opacity: { value: 1 } },
});Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
three.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Bugs rules from the rules reference:
react-doctor/three-tsl-no-js-uniform-branch: JavaScript branch reads a TSL uniform valuereact-doctor/three-webgpu-no-legacy-effect-composer: Legacy EffectComposer used with WebGPURendererreact-doctor/three-webgpu-no-legacy-material-api: Legacy material API used with WebGPURendererreact-doctor/valtio-no-proxy-read-in-render: Valtio proxy read during renderreact-doctor/valtio-no-snapshot-in-callback: Valtio snapshot read in a callback