`react-doctor/three-shader-prefer-squared-distance-comparison`

Shader compares a computed distance

Category: Performance
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: three
Tags: three, webgl
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/three-shader-prefer-squared-distance-comparison. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

if (distance(position, target) < radius) {
  color = highlight;
}

Corrected pattern

vec3 offset = position - target;
if (dot(offset, offset) < radius * radius) {
  color = highlight;
}

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/three-shader-prefer-squared-distance-comparison diagnostic in the current repository. Required change: - Compare squared vector distance against a squared nonnegative threshold.

Reference transformation:Before:

if (distance(position, target) < radius) {
  color = highlight;
}

After:

vec3 offset = position - target;
if (dot(offset, offset) < radius * radius) {
  color = highlight;
}

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: three. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Performance rules from the rules reference:

react-doctor/use-lazy-motion: Use `import { LazyMotion, m } from "framer-motion"` with `domAnimation` features — saves ~30kb
react-doctor/webgl-no-sync-readback-in-animation-loop: Synchronous GPU readback inside animation loop
react-doctor/zustand-no-fresh-selector-result: Zustand selector returns a fresh value
react-doctor/advanced-event-handler-refs: Store the handler in a ref and have the listener read `handlerRef.current()` — the subscription stays put while the latest handler is always called
react-doctor/async-await-in-loop: Collect the items and use `await Promise.all(items.map(...))` to run independent operations concurrently

react-doctor/three-shader-prefer-squared-distance-comparison