react-doctor/three-require-owned-texture-cleanup
Locally owned Three.js texture is not disposed
- Category: Performance
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: react, three
- Tags: three, webgl
- Disabled when: r3f
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/three-require-owned-texture-cleanup. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
useEffect(() => {
material.map = new DataTexture(data, width, height);
}, [data, height, material, width]);Corrected pattern
useEffect(() => {
const texture = new DataTexture(data, width, height);
material.map = texture;
return () => texture.dispose();
}, [data, height, material, width]);How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/three-require-owned-texture-cleanup diagnostic in the current repository.
Required change:
- Dispose locally constructed textures when their React owner releases them.useEffect(() => {
material.map = new DataTexture(data, width, height);
}, [data, height, material, width]);useEffect(() => {
const texture = new DataTexture(data, width, height);
material.map = texture;
return () => texture.dispose();
}, [data, height, material, width]);Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
react, three.
- Do not edit code when this condition applies: r3f.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Performance rules from the rules reference:
react-doctor/three-shader-no-inverse-of-uniform: Shader inverts a uniform matrix per invocationreact-doctor/three-shader-no-redundant-frag-depth: Shader redundantly writes fragment depthreact-doctor/three-shader-prefer-small-integer-pow: Shader uses pow for a small integer exponentreact-doctor/three-shader-prefer-squared-distance-comparison: Shader compares a computed distancereact-doctor/use-lazy-motion: Use `import { LazyMotion, m } from "framer-motion"` with `domAnimation` features — saves ~30kb