react-doctor/three-require-instanced-buffer-update
Three.js instanced mesh buffer is not marked for upload
- Category: Bugs
- Severity: error
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: three
- Tags: three, webgl
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/three-require-instanced-buffer-update. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
mesh.setColorAt(index, color);Corrected pattern
mesh.setColorAt(index, color);
mesh.instanceColor.needsUpdate = true;How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/three-require-instanced-buffer-update diagnostic in the current repository.
Required change:
- After setMatrixAt or setColorAt, set the matching instance buffer's needsUpdate flag to true.mesh.setColorAt(index, color);mesh.setColorAt(index, color);
mesh.instanceColor.needsUpdate = true;Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
three.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Bugs rules from the rules reference:
react-doctor/three-require-postprocessing-cleanup: Undisposed Three.js postprocessing resourcereact-doctor/three-require-projection-matrix-update: Missing Three.js camera projection-matrix updatereact-doctor/three-require-render-target-cleanup: Undisposed Three.js render targetreact-doctor/three-require-renderer-cleanup: Undisposed Three.js rendererreact-doctor/three-shader-no-constant-out-of-bounds-index: Shader uses a constant out-of-bounds index