react-doctor/three-no-clone-in-animation-loop
Three.js clone inside animation loop
- Category: Performance
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: three
- Tags: three, webgl
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/three-no-clone-in-animation-loop. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
renderer.setAnimationLoop(() => {
mesh.position.copy(target.clone().normalize());
});Corrected pattern
const scratch = new Vector3();
renderer.setAnimationLoop(() => {
mesh.position.copy(scratch.copy(target).normalize());
});How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/three-no-clone-in-animation-loop diagnostic in the current repository.
Required change:
- Clone once before the animation loop or copy values into a reusable scratch object during frames.renderer.setAnimationLoop(() => {
mesh.position.copy(target.clone().normalize());
});const scratch = new Vector3();
renderer.setAnimationLoop(() => {
mesh.position.copy(scratch.copy(target).normalize());
});Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
three.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Performance rules from the rules reference:
react-doctor/three-no-material-recompile-in-animation-loop: Material recompiled inside animation loopreact-doctor/three-no-new-in-animation-loop: Allocation inside Three.js animation loopreact-doctor/three-no-object-construction-in-render: Three.js object constructed during React renderreact-doctor/three-no-redundant-uniforms-need-update: Redundant uniformsNeedUpdate inside animation loopreact-doctor/three-no-state-in-animation-loop: React state update inside Three.js animation loop