react-doctor/role-button-requires-complete-keyboard-activation
ARIA button handles only one activation key
- Category: Accessibility
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: react
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/role-button-requires-complete-keyboard-activation. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
const Control = ({ activate }) => (
<div
role="button"
tabIndex={0}
onClick={activate}
onKeyDown={(event) => {
if (event.key === "Enter") activate();
}}
/>
);Corrected pattern
const Control = ({ activate }) => (
<button type="button" onClick={activate} />
);How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/role-button-requires-complete-keyboard-activation diagnostic in the current repository.
Required change:
- Use a native button, or make a custom role button activate with both Enter and Space.const Control = ({ activate }) => (
<div
role="button"
tabIndex={0}
onClick={activate}
onKeyDown={(event) => {
if (event.key === "Enter") activate();
}}
/>
);const Control = ({ activate }) => (
<button type="button" onClick={activate} />
);Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Preserve accessible names, focus order, keyboard behavior, and touch access not targeted by this rule.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
react.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Accessibility rules from the rules reference:
react-doctor/role-has-required-aria-props: Require elements with an ARIA role to carry that role's required aria-* state props, like aria-checked on role='checkbox'.react-doctor/role-supports-aria-props: Use only aria-* props that are supported by the element's explicit or implicit ARIA role.react-doctor/scope: Disallow the scope attribute on elements other than th — it is only defined for table header cells.react-doctor/tabindex-no-positive: Disallow positive tabIndex values, which override the natural tab order and make focus jump unpredictably.react-doctor/alt-text: Require alternative text on img, area, input[type='image'], and object elements so screen readers can describe them.