`react-doctor/react-router-no-nested-router`

Router nested inside another router

Category: Bugs
Severity: error
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: react-router
Tags: react-jsx-only
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/react-router-no-nested-router. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

<BrowserRouter>
  <App>
    <MemoryRouter><Wizard /></MemoryRouter>
  </App>
</BrowserRouter>

Corrected pattern

<BrowserRouter>
  <App>
    <Wizard />
  </App>
</BrowserRouter>

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/react-router-no-nested-router diagnostic in the current repository. Required change: - Keep one router provider at the application root.

Reference transformation:Before:

<BrowserRouter>
  <App>
    <MemoryRouter><Wizard /></MemoryRouter>
  </App>
</BrowserRouter>

After:

<BrowserRouter>
  <App>
    <Wizard />
  </App>
</BrowserRouter>

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: react-router. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/react-router-no-redirect-in-try-catch: redirect() inside try-catch
react-doctor/react-router-no-route-module-environment-suffix: Route module has an environment suffix
react-doctor/react-router-no-router-in-render: Router created during render
react-doctor/react-router-no-session-mutation-in-loader: Loader mutates session state
react-doctor/react-router-no-static-cookie-expires: Cookie expiry is fixed at module load

react-doctor/react-router-no-nested-router