`react-doctor/react-router-no-catch-middleware-next`

Middleware catch cannot observe downstream errors

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: react-router:7.8, react-router-framework
Tags: test-noise
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/react-router-no-catch-middleware-next. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

export const middleware = [async (_, next) => {
  try {
    return await next();
  } catch (error) {
    return new Response("Failed", { status: 500 });
  }
}];

Corrected pattern

export const ErrorBoundary = () => <p>Failed</p>;
export const middleware = [
  async (_, next) => next(),
];

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/react-router-no-catch-middleware-next diagnostic in the current repository. Required change: - Use an ErrorBoundary, handleError, or middleware response instrumentation instead of catching next().

Reference transformation:Before:

export const middleware = [async (_, next) => {
  try {
    return await next();
  } catch (error) {
    return new Response("Failed", { status: 500 });
  }
}];

After:

export const ErrorBoundary = () => <p>Failed</p>;
export const middleware = [
  async (_, next) => next(),
];

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: react-router:7.8, react-router-framework. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/react-router-no-client-module-in-server-render: Client-only module rendered on the server
react-doctor/react-router-no-duplicate-route-id: Duplicate route ID
react-doctor/react-router-no-empty-leaf-route: Leaf route renders nothing
react-doctor/react-router-no-invalid-absolute-child-path: Absolute child path escapes its parent
react-doctor/react-router-no-invalid-lazy-route-properties: Immutable route property returned from lazy

react-doctor/react-router-no-catch-middleware-next