react-doctor/react-router-loader-fetch-forwards-signal
Loader fetch ignores cancellation
- Category: Performance
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: react, react-router:6.4
- Tags: test-noise
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/react-router-loader-fetch-forwards-signal. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
export const loader = async ({ request }) => {
return fetch("/api/project");
};Corrected pattern
export const loader = async ({ request }) => {
return fetch("/api/project", { signal: request.signal });
};How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/react-router-loader-fetch-forwards-signal diagnostic in the current repository.
Required change:
- Pass request.signal to fetch so superseded navigations cancel work that no longer contributes to the route.export const loader = async ({ request }) => {
return fetch("/api/project");
};export const loader = async ({ request }) => {
return fetch("/api/project", { signal: request.signal });
};Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
react, react-router:6.4.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Performance rules from the rules reference:
react-doctor/react-router-loader-parallel-fetch: Independent loader work runs sequentiallyreact-doctor/react-router-prefer-route-lazy: React.lazy creates a route-module waterfallreact-doctor/redux-useselector-inline-derivation: Select the raw slice in useSelector and derive with useMemo, or hoist into a memoised createSelector from reselect.react-doctor/redux-useselector-returns-new-collection: useSelector that returns a fresh object/array literal re-renders on every action; return a primitive, split into multiple useSelector calls, or pass shallowEqual.react-doctor/rendering-animate-svg-wrapper: Wrap the SVG: `<motion.div animate={...}><svg>...</svg></motion.div>`