react-doctor/r3f-no-manual-canvas-resize
Manual resize loop for an R3F-owned renderer
- Category: Performance
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: react, r3f
- Tags: r3f, webgl
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/r3f-no-manual-canvas-resize. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
const Scene = () => {
const gl = useThree((state) => state.gl);
useEffect(() => {
const resize = () => gl.setSize(innerWidth, innerHeight);
addEventListener("resize", resize);
return () => removeEventListener("resize", resize);
}, [gl]);
return <mesh />;
};Corrected pattern
const Scene = () => <mesh />;How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/r3f-no-manual-canvas-resize diagnostic in the current repository.
Required change:
- Let Canvas and its ResizeObserver own renderer sizing instead of registering a window resize loop.const Scene = () => {
const gl = useThree((state) => state.gl);
useEffect(() => {
const resize = () => gl.setSize(innerWidth, innerHeight);
addEventListener("resize", resize);
return () => removeEventListener("resize", resize);
}, [gl]);
return <mesh />;
};const Scene = () => <mesh />;Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
react, r3f.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.Related rules
More Performance rules from the rules reference:
react-doctor/r3f-no-new-in-use-frame: Allocation inside useFramereact-doctor/r3f-no-recursive-raf-with-use-frame: Competing animation loop alongside useFramereact-doctor/r3f-no-state-in-pointer-move: React state update inside an R3F pointer-move handlerreact-doctor/r3f-no-state-in-use-frame: React state update inside useFramereact-doctor/r3f-no-sync-readback-in-use-frame: Synchronous readback inside useFrame