New
Introducing React Bench, see how different models perform on React code

react-doctor/preact-no-render-arguments

Drop render's positional params and read this.props / this.state inside render() instead

Status
Active
Category
Preact
Assessment
Evidence-required risk
Required evidence
source code
Default configuration
Enabled
Default severity
warn
Show technical metadata
Scope
Preact
Active when
framework=preact and capabilities=preact
Requirements
preact
Priority
30 (P3)
Source
oxlint-plugin-react-doctor
Rule set
oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
On this page

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires on a non-static instance MethodDefinition named render (kind 'method', static !== true) whose owning class extends Component or PureComponent: imported from preact, or referenced as the Preact namespace member Preact.Component / Preact.PureComponent, or the React.Component shape that isEs6Component recognizes (e.g. preact/compat): when that render's FunctionExpression declares at least one runtime parameter (props, or props plus state). A leading TypeScript this: type-only parameter is stripped first, so it does not count. False positive boundary mirroring the valid fixtures: parameterless render() reading this.props/this.state; a render(target) on a plain class that does NOT extend a Component/PureComponent base; a function component or arrow assigned const render = (props) => ...; a static render(input) utility sharing the name; and render(this: Hello) where the only param is the type-only this binding with an otherwise empty runtime arg list.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

  • Confirmed failure: The required evidence establishes the violation.
  • Rejected: A documented exception or false-positive predicate applies.
  • Needs evidence: Named evidence can still be collected.
  • Unavailable: Required evidence cannot be collected in this run.
  • Waived with evidence: An authorized, scoped exception applies to an established failure.
  • Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Remove the positional parameter(s) from the lifecycle render() and read the same values off the instance instead: change render(props, state) { return <h1>{props.name} {state.count}</h1>; } to render() { return <h1>{this.props.name} {this.state.count}</h1>; }. This types cleanly via Component<Props, State>, keeps render() consistent with every other lifecycle method, and survives a switch to preact/compat where render() takes no arguments. Leave a genuine this: type annotation in place but delete the user-declared props/state params after it. See https://preactjs.com/guide/v10/components/

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.

Show repository-wide prompt

Fix every confirmed react-doctor/preact-no-render-arguments diagnostic in the current repository.

Required change:

  • Remove the positional parameter(s) from the lifecycle render() and read the same values off the instance instead: change render(props, state) { return <h1>{props.name} {state.count}</h1>; } to render() { return <h1>{this.props.name} {this.state.count}</h1>; }. This types cleanly via Component<Props, State>, keeps render() consistent with every other lifecycle method, and survives a switch to preact/compat where render() takes no arguments. Leave a genuine this: type annotation in place but delete the user-declared props/state params after it. See https://preactjs.com/guide/v10/components/.

Validation before editing:

Fires on a non-static instance MethodDefinition named render (kind 'method', static !== true) whose owning class extends Component or PureComponent: imported from preact, or referenced as the Preact namespace member Preact.Component / Preact.PureComponent, or the React.Component shape that isEs6Component recognizes (e.g. preact/compat): when that render's FunctionExpression declares at least one runtime parameter (props, or props plus state). A leading TypeScript this: type-only parameter is stripped first, so it does not count. False positive boundary mirroring the valid fixtures: parameterless render() reading this.props/this.state; a render(target) on a plain class that does NOT extend a Component/PureComponent base; a function component or arrow assigned const render = (props) => ...; a static render(input) utility sharing the name; and render(this: Hello) where the only param is the type-only this binding with an otherwise empty runtime arg list.

Constraints:

  • Make the smallest change that fixes the root cause.
  • Preserve behavior and interfaces unrelated to this diagnostic.
  • Reuse existing project components, utilities, and conventions.
  • Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
  • Adapt identifiers and framework details instead of copying blindly.
  • Do not disable the rule or suppress matching code.
  • Confirm this rule is enabled for the project: framework=preact and capabilities=preact.

Assessment:

  • Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
  • Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
  • A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

Verification:

  • Run focused tests for the changed behavior.
  • Run React Doctor and confirm this diagnostic no longer appears from changed code.
  • Run an unfiltered scan of the affected scope before claiming no cross-category regression.
  • Report the files changed and any checks you could not run.