`react-doctor/no-whole-object-dep-with-member-reads`

Whole props object in deps while only members are read

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: react
Tags: test-noise
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/no-whole-object-dep-with-member-reads. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

import { useMemo } from "react";
const Panel = (props) => useMemo(() => props.user.format(), [props]);

Corrected pattern

import { useMemo } from "react";
const Panel = (props) => {
  const { user } = props;
  return useMemo(() => user.format(), [user]);
};

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/no-whole-object-dep-with-member-reads diagnostic in the current repository. Required change: - Destructure the fields you read and depend on those bindings instead of the whole props object.

Reference transformation:Before:

import { useMemo } from "react";
const Panel = (props) => useMemo(() => props.user.format(), [props]);

After:

import { useMemo } from "react";
const Panel = (props) => {
  const { user } = props;
  return useMemo(() => user.format(), [user]);
};

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: react. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/no-will-update-set-state: Don't call this.setState in componentWillUpdate — move the update to getDerivedStateFromProps or componentDidUpdate.
react-doctor/pointer-capture-needs-cancel-handler: Captured pointer interaction has no cancellation path
react-doctor/preact-no-children-length: Wrap with toChildArray(children) from preact before reading .length or calling array methods on props.children.
react-doctor/preact-no-react-hooks-import: Import hooks from `preact/hooks` (or `preact/compat`), not `react`: import { useState } from "preact/hooks"
react-doctor/preact-no-render-arguments: Drop render's positional params and read this.props / this.state inside render() instead

react-doctor/no-whole-object-dep-with-member-reads