react-doctor/no-unstable-nested-components

Hoist nested components to module scope or memoize them: never define one inside another.

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires when a component candidate is defined inside an enclosing React component (or class render method): a candidate being a PascalCase-named function/class, a function passed as a JSX prop value, or an object-property callback inside a call/array: whose body contains JSX or React.createElement. Excluded: useCallback-wrapped functions, .map/.forEach/.filter/.flatMap/.reduce callbacks, the children prop, render-prop names matching render*, and the first argument of an HoC (memo/forwardRef/lazy/observer: the outer call is reported instead).

Suppress when: with the default allowAsProps:true, a render-prop component passed via a prop (e.g. footer={() => <div/>}) is the canonical composition pattern and is NOT flagged: only inline definitions in the render body that remount on every render are real findings.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

• Confirmed failure: The required evidence establishes the violation.
• Rejected: A documented exception or false-positive predicate applies.
• Needs evidence: Named evidence can still be collected.
• Unavailable: Required evidence cannot be collected in this run.
• Waived with evidence: An authorized, scoped exception applies to an established failure.
• Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Move a nested component to module scope and pass captured values as props so its component identity remains stable. If the function is only a local render helper, give it a lowercase name and call it as a function rather than rendering it as <Component />. Do not wrap a nested component in useCallback: dependency changes still create a new component type and even an empty dependency list does not establish module-level identity across remounts or instances. Keep intentional render-prop callbacks covered by allowAsProps. See https://oxc.rs/docs/guide/usage/linter/rules/react/no-unstable-nested-components

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.