react-doctor/no-unsafe
Replace UNSAFE_componentWillMount / WillReceiveProps / WillUpdate with their modern lifecycle equivalents.
- Status
- Active
- Category
- Correctness
- Assessment
- Evidence-required risk
- Required evidence
- source code
- Default configuration
- Enabled
- Default severity
- warn
Show technical metadata
- Scope
- All supported frameworks
- Active when
- always
- Requirements
- react
- Priority
- 34 (P3)
- Source
- oxlint-plugin-react-doctor
- Rule set
- oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
- Documentation
- Official documentation
Validation prompt
Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.
Fires when a React class component (detected via getParentComponent) or a createReactClass ES5 component defines a method/property named UNSAFE_componentWillMount, UNSAFE_componentWillReceiveProps, or UNSAFE_componentWillUpdate; the non-prefixed aliases (componentWillMount etc.) are only flagged when settings.react-doctor.noUnsafe.checkAliases is true. The prefixed methods are additionally skipped when settings.react.version is below 16.3 (an unknown version is treated as modern and still flagged). False positive boundary: an identically named method on a class that is NOT a React component (e.g. extends Bar, a plain helper class) is correctly NOT flagged: confirm the enclosing class actually extends React.Component / PureComponent or is a createReactClass call before acting.
Evidence boundary
The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.
Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.
Record one outcome:
- Confirmed failure: The required evidence establishes the violation.
- Rejected: A documented exception or false-positive predicate applies.
- Needs evidence: Named evidence can still be collected.
- Unavailable: Required evidence cannot be collected in this run.
- Waived with evidence: An authorized, scoped exception applies to an established failure.
- Observation: The review records an optional tradeoff without claiming a defect.
A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.
Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.
Fix prompt
Apply this candidate correction only after the required evidence confirms the risk.
Migrate each unsafe lifecycle to its async-safe replacement: move side effects from componentWillMount to componentDidMount, derive prop-driven state in static getDerivedStateFromProps(props, state) instead of componentWillReceiveProps, and capture pre-update info in getSnapshotBeforeUpdate / handle it in componentDidUpdate instead of componentWillUpdate. For most components, prefer porting the class to a function component with hooks (useEffect, useState). See https://oxc.rs/docs/guide/usage/linter/rules/react/no-unsafe
Repository-wide copy prompt
Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.
Show repository-wide prompt
Fix every confirmed react-doctor/no-unsafe diagnostic in the current repository.
Required change:
- Migrate each unsafe lifecycle to its async-safe replacement: move side effects from componentWillMount to componentDidMount, derive prop-driven state in static getDerivedStateFromProps(props, state) instead of componentWillReceiveProps, and capture pre-update info in getSnapshotBeforeUpdate / handle it in componentDidUpdate instead of componentWillUpdate. For most components, prefer porting the class to a function component with hooks (useEffect, useState). See https://oxc.rs/docs/guide/usage/linter/rules/react/no-unsafe.
Validation before editing:
Fires when a React class component (detected via getParentComponent) or a createReactClass ES5 component defines a method/property named UNSAFE_componentWillMount, UNSAFE_componentWillReceiveProps, or UNSAFE_componentWillUpdate; the non-prefixed aliases (componentWillMount etc.) are only flagged when settings.react-doctor.noUnsafe.checkAliases is true. The prefixed methods are additionally skipped when settings.react.version is below 16.3 (an unknown version is treated as modern and still flagged). False positive boundary: an identically named method on a class that is NOT a React component (e.g. extends Bar, a plain helper class) is correctly NOT flagged: confirm the enclosing class actually extends React.Component / PureComponent or is a createReactClass call before acting.
Constraints:
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears from changed code.
- Run an unfiltered scan of the affected scope before claiming no cross-category regression.
- Report the files changed and any checks you could not run.