react-doctor/no-this-in-sfc
Use the function's `props` parameter instead of `this.props` in stateless function components.
- Status
- Active
- Category
- Correctness
- Assessment
- Evidence-required risk
- Required evidence
- source code
- Default configuration
- Enabled
- Default severity
- warn
Show technical metadata
- Scope
- All supported frameworks
- Active when
- always
- Requirements
- react
- Priority
- 34 (P3)
- Source
- oxlint-plugin-react-doctor
- Rule set
- oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
- Documentation
- Official documentation
Validation prompt
Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.
Fires on a this.<member> access (member expression or this["props"] bracket form) inside a function component, identified purely by a PascalCase name: a function Foo, or a function/arrow assigned to a PascalCase variable or assignment target. Excluded: class methods, ES5 createReactClass/configured class-factory components, functions with an explicit TS this: parameter, and object-property methods (e.g. Tiptap/ProseMirror .extend({ addAttributes() {…} })).
Suppress when: the detection is name-based, not JSX-based, so a PascalCase-named helper that is NOT a React component (a factory, hook-like builder, or utility returning a plain object) is flagged even though its this is a legitimate non-component binding.
Evidence boundary
The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.
Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.
Record one outcome:
- Confirmed failure: The required evidence establishes the violation.
- Rejected: A documented exception or false-positive predicate applies.
- Needs evidence: Named evidence can still be collected.
- Unavailable: Required evidence cannot be collected in this run.
- Waived with evidence: An authorized, scoped exception applies to an established failure.
- Observation: The review records an optional tradeoff without claiming a defect.
A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.
Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.
Fix prompt
Apply this candidate correction only after the required evidence confirms the risk.
Read props and context from the function's parameters instead of this: destructure them in the signature: function Foo({ foo }) { return <div>{foo}</div>; }: or accept a props argument and use props.foo. If the function is genuinely not a stateless component (a class-related helper, a builder, or an object-config method), declare an explicit TypeScript this: parameter or rename it to non-PascalCase so the rule correctly skips it. See https://oxc.rs/docs/guide/usage/linter/rules/react/no-this-in-sfc
Repository-wide copy prompt
Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.
Show repository-wide prompt
Fix every confirmed react-doctor/no-this-in-sfc diagnostic in the current repository.
Required change:
- Read props and context from the function's parameters instead of
this: destructure them in the signature:function Foo({ foo }) { return <div>{foo}</div>; }: or accept apropsargument and useprops.foo. If the function is genuinely not a stateless component (a class-related helper, a builder, or an object-config method), declare an explicit TypeScriptthis:parameter or rename it to non-PascalCase so the rule correctly skips it. See https://oxc.rs/docs/guide/usage/linter/rules/react/no-this-in-sfc.
Validation before editing:
Fires on a this.<member> access (member expression or this["props"] bracket form) inside a function component, identified purely by a PascalCase name: a function Foo, or a function/arrow assigned to a PascalCase variable or assignment target. Excluded: class methods, ES5 createReactClass/configured class-factory components, functions with an explicit TS this: parameter, and object-property methods (e.g. Tiptap/ProseMirror .extend({ addAttributes() {…} })).
Suppress when: the detection is name-based, not JSX-based, so a PascalCase-named helper that is NOT a React component (a factory, hook-like builder, or utility returning a plain object) is flagged even though its this is a legitimate non-component binding.
Constraints:
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears from changed code.
- Run an unfiltered scan of the affected scope before claiming no cross-category regression.
- Report the files changed and any checks you could not run.