`react-doctor/no-set-state-after-await-in-effect`

State update after await in an effect

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: react
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/no-set-state-after-await-in-effect. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

const C = ({ id }) => {
  const [, setValue] = useState();
  useEffect(() => {
    const controller = new AbortController();
    const run = async () => {
      await load(id, { signal: controller.signal });
      setValue(id);
    };
    run();
    return () => {
      const controller = new AbortController();
      controller.abort();
    };
  }, [id]);
};

Corrected pattern

const C = ({ id, reportError }) => {
  const [, setValue] = useState();
  useEffect(() => {
    const controller = new AbortController();
    const run = async () => {
      await load(id, { signal: controller.signal });
      if (!controller.signal.aborted) setValue(id);
    };
    void run().catch((error) => {
      if (!controller.signal.aborted) reportError(error);
    });
    return () => controller.abort();
  }, [id, reportError]);
};

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/no-set-state-after-await-in-effect diagnostic in the current repository. Required change: - In effects with changing dependencies, ignore or cancel stale async work before any post-await state update.

Reference transformation:Before:

const C = ({ id }) => {
  const [, setValue] = useState();
  useEffect(() => {
    const controller = new AbortController();
    const run = async () => {
      await load(id, { signal: controller.signal });
      setValue(id);
    };
    run();
    return () => {
      const controller = new AbortController();
      controller.abort();
    };
  }, [id]);
};

After:

const C = ({ id, reportError }) => {
  const [, setValue] = useState();
  useEffect(() => {
    const controller = new AbortController();
    const run = async () => {
      await load(id, { signal: controller.signal });
      if (!controller.signal.aborted) setValue(id);
    };
    void run().catch((error) => {
      if (!controller.signal.aborted) reportError(error);
    });
    return () => controller.abort();
  }, [id, reportError]);
};

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: react. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/no-set-state-in-render: Move the setter call into a `useEffect`, an event handler, or replace the state with a value computed during render. Calling a setter at render time triggers another render, which calls the setter again — an infinite loop
react-doctor/no-side-effect-in-state-updater-function: Side effect inside a state updater function
react-doctor/no-spread-props-over-defaults-clobbers-with-undefined: Spread props over defaults can clobber with undefined
react-doctor/no-stale-timer-ref: Cleared timer ref keeps the stale id
react-doctor/no-static-motion-config-never: MotionConfig always ignores reduced motion

react-doctor/no-set-state-after-await-in-effect