New
Introducing React Bench, see how different models perform on React code

react-doctor/no-set-state

Lift state up or use an external store instead of this.setState.

Status
Active
Category
Architecture
Assessment
Evidence-required risk
Required evidence
source code, repository context
Default configuration
Disabled until configured
Default severity
warn
Show technical metadata
Scope
All supported frameworks
Active when
off by default (opt-in)
Requirements
react
Priority
18 (P3)
Source
oxlint-plugin-react-doctor
Rule set
oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
On this page

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires on a this.setState(...) call expression whose callee is exactly this.setState and that sits inside a recognized React component: an es5 createReactClass({...}) or an es6 class extends React.Component. It does NOT fire on this.setState used in a plain function that isn't a component, nor on merely referencing the method without invoking it (e.g. this.someHandler = this.setState).

Suppress when: a legitimate class component kept on purpose: error boundaries, third-party/legacy integrations, or code not yet migrated: where local class state is still the correct tool; this is a style/architecture rule, so confirm the codebase has actually committed to banning class state before flagging.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

  • Confirmed failure: The required evidence establishes the violation.
  • Rejected: A documented exception or false-positive predicate applies.
  • Needs evidence: Named evidence can still be collected.
  • Unavailable: Required evidence cannot be collected in this run.
  • Waived with evidence: An authorized, scoped exception applies to an established failure.
  • Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Move the state out of the class: lift it to a parent and pass it down as props, or back it with an external store (Redux/Zustand/Flux) and dispatch instead of calling this.setState({count}). Where the component itself should own the state, convert it to a function component and use a hook: const [count, setCount] = useState(0). If this class component must stay (e.g. an error boundary), suppress the finding on that line with a written justification. See https://oxc.rs/docs/guide/usage/linter/rules/react/no-set-state

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.

Show repository-wide prompt

Fix every confirmed react-doctor/no-set-state diagnostic in the current repository.

Required change:

  • Move the state out of the class: lift it to a parent and pass it down as props, or back it with an external store (Redux/Zustand/Flux) and dispatch instead of calling this.setState({count}). Where the component itself should own the state, convert it to a function component and use a hook: const [count, setCount] = useState(0). If this class component must stay (e.g. an error boundary), suppress the finding on that line with a written justification. See https://oxc.rs/docs/guide/usage/linter/rules/react/no-set-state.

Validation before editing:

Fires on a this.setState(...) call expression whose callee is exactly this.setState and that sits inside a recognized React component: an es5 createReactClass({...}) or an es6 class extends React.Component. It does NOT fire on this.setState used in a plain function that isn't a component, nor on merely referencing the method without invoking it (e.g. this.someHandler = this.setState).

Suppress when: a legitimate class component kept on purpose: error boundaries, third-party/legacy integrations, or code not yet migrated: where local class state is still the correct tool; this is a style/architecture rule, so confirm the codebase has actually committed to banning class state before flagging.

Constraints:

  • Make the smallest change that fixes the root cause.
  • Preserve behavior and interfaces unrelated to this diagnostic.
  • Reuse existing project components, utilities, and conventions.
  • Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
  • Adapt identifiers and framework details instead of copying blindly.
  • Do not disable the rule or suppress matching code.
  • Confirm this rule is enabled for the project: off by default (opt-in).

Assessment:

  • Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
  • Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
  • A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

Verification:

  • Run focused tests for the changed behavior.
  • Run React Doctor and confirm this diagnostic no longer appears from changed code.
  • Run an unfiltered scan of the affected scope before claiming no cross-category regression.
  • Report the files changed and any checks you could not run.