New
Introducing React Bench, see how different models perform on React code

react-doctor/no-react-children

Pass children as props or render them directly instead of calling React.Children methods.

Status
Active
Category
Architecture
Assessment
Evidence-required risk
Required evidence
source code, repository context
Default configuration
Disabled until configured
Default severity
warn
Show technical metadata
Scope
All supported frameworks
Active when
off by default (opt-in)
Requirements
react
Priority
18 (P3)
Source
oxlint-plugin-react-doctor
Rule set
oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
On this page

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires on a call whose callee is a member access on the React Children namespace: either Children.<method>(...) where Children was imported from 'react', or React.Children.<method>(...) where React is the local name of any react import (covering map, forEach, only, count, toArray, and the parenthesized or as any forms). It does NOT fire on a locally-declared Children object, a Children imported from a non-react module, or the bare strings/JSX text "Children".

Suppress when: React.Children.only / React.Children.map used as a deliberate runtime invariant (e.g. enforcing a single child in a tooltip or trigger wrapper): that is a valid, intentional pattern, not a bug, which is exactly why this rule ships off by default.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

  • Confirmed failure: The required evidence establishes the violation.
  • Rejected: A documented exception or false-positive predicate applies.
  • Needs evidence: Named evidence can still be collected.
  • Unavailable: Required evidence cannot be collected in this run.
  • Waived with evidence: An authorized, scoped exception applies to an established failure.
  • Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Prefer rendering children directly, accepting explicit node props, or mapping an explicit data/slot array instead of introspecting an opaque children collection. Keep React.Children.only/map when it deliberately enforces or transforms the public children contract, and document or suppress that opt-in use. Do not replace a valid render callback with Children inspection when the child needs data owned by the parent. See https://oxc.rs/docs/guide/usage/linter/rules/react/no-react-children

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.

Show repository-wide prompt

Fix every confirmed react-doctor/no-react-children diagnostic in the current repository.

Required change:

  • Prefer rendering children directly, accepting explicit node props, or mapping an explicit data/slot array instead of introspecting an opaque children collection. Keep React.Children.only/map when it deliberately enforces or transforms the public children contract, and document or suppress that opt-in use. Do not replace a valid render callback with Children inspection when the child needs data owned by the parent. See https://oxc.rs/docs/guide/usage/linter/rules/react/no-react-children.

Validation before editing:

Fires on a call whose callee is a member access on the React Children namespace: either Children.<method>(...) where Children was imported from 'react', or React.Children.<method>(...) where React is the local name of any react import (covering map, forEach, only, count, toArray, and the parenthesized or as any forms). It does NOT fire on a locally-declared Children object, a Children imported from a non-react module, or the bare strings/JSX text "Children".

Suppress when: React.Children.only / React.Children.map used as a deliberate runtime invariant (e.g. enforcing a single child in a tooltip or trigger wrapper): that is a valid, intentional pattern, not a bug, which is exactly why this rule ships off by default.

Constraints:

  • Make the smallest change that fixes the root cause.
  • Preserve behavior and interfaces unrelated to this diagnostic.
  • Reuse existing project components, utilities, and conventions.
  • Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
  • Adapt identifiers and framework details instead of copying blindly.
  • Do not disable the rule or suppress matching code.
  • Confirm this rule is enabled for the project: off by default (opt-in).

Assessment:

  • Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
  • Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
  • A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

Verification:

  • Run focused tests for the changed behavior.
  • Run React Doctor and confirm this diagnostic no longer appears from changed code.
  • Run an unfiltered scan of the affected scope before claiming no cross-category regression.
  • Report the files changed and any checks you could not run.