react-doctor/no-prop-types
Move propTypes to TypeScript types: `type Props = { value: number }; function Component(props: Props)`: React 19 ignores runtime propTypes
- Status
- Active
- Category
- Architecture
- Assessment
- Evidence-required risk
- Required evidence
- source code, repository context
- Default configuration
- Disabled until configured
- Default severity
- warn
Show technical metadata
- Scope
- All supported frameworks
- Active when
- always
- Requirements
- react:19
- Tags
- test-noise
- Priority
- 46 (P3)
- Source
- oxlint-plugin-react-doctor
- Rule set
- oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
- Documentation
- Official documentation
Validation prompt
Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.
Fires on two idioms whose receiver is a Capitalized identifier/class name: (1) an AssignmentExpression with operator '=' whose left is a MemberExpression with a 'propTypes' property (Identifier key, or computed Literal 'propTypes') on an Identifier object that passes the uppercase-name test, e.g. Component.propTypes = { value: PropTypes.number }; and (2) a static PropertyDefinition keyed 'propTypes' inside a ClassBody whose class (ClassDeclaration/ClassExpression id, or the VariableDeclarator id binding a ClassExpression) is uppercase-named, e.g. class Component { static propTypes = {...} }. The uppercase-receiver heuristic deliberately excludes lowercase objects, so config.propTypes = {...} or options.propTypes is never flagged: suppress those as well as any non-component object that happens to expose a propTypes field. The rule is version-gated upstream in the oxlint plugin source (requires react:19), so a flagged finding is already on a React 19+ project; still suppress if you can establish the code is genuinely pre-React-19, where propTypes still runs.
Evidence boundary
The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.
Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.
Record one outcome:
- Confirmed failure: The required evidence establishes the violation.
- Rejected: A documented exception or false-positive predicate applies.
- Needs evidence: Named evidence can still be collected.
- Unavailable: Required evidence cannot be collected in this run.
- Waived with evidence: An authorized, scoped exception applies to an established failure.
- Observation: The review records an optional tradeoff without claiming a defect.
A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.
Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.
Fix prompt
Apply this candidate correction only after the required evidence confirms the risk.
Delete the propTypes object (and the prop-types import) and describe the contract with a TypeScript prop type instead: type ComponentProps = { value: number; onChange: (v: number) => void }, then annotate the component as function Component(props: ComponentProps) or class Component extends React.Component<ComponentProps>. propTypes also validated values at runtime: React 19 no longer does: so for props carrying genuinely untrusted external data, add an explicit runtime check or schema parse (e.g. zod) in the component body rather than relying on the removed propTypes mechanism. See https://react.dev/blog/2024/12/05/react-19#removed-proptypes-and-defaultprops
Repository-wide copy prompt
Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.
Show repository-wide prompt
Fix every confirmed react-doctor/no-prop-types diagnostic in the current repository.
Required change:
- Delete the propTypes object (and the prop-types import) and describe the contract with a TypeScript prop type instead: type ComponentProps = { value: number; onChange: (v: number) => void }, then annotate the component as function Component(props: ComponentProps) or class Component extends React.Component<ComponentProps>. propTypes also validated values at runtime: React 19 no longer does: so for props carrying genuinely untrusted external data, add an explicit runtime check or schema parse (e.g. zod) in the component body rather than relying on the removed propTypes mechanism. See https://react.dev/blog/2024/12/05/react-19#removed-proptypes-and-defaultprops.
Validation before editing:
Fires on two idioms whose receiver is a Capitalized identifier/class name: (1) an AssignmentExpression with operator '=' whose left is a MemberExpression with a 'propTypes' property (Identifier key, or computed Literal 'propTypes') on an Identifier object that passes the uppercase-name test, e.g. Component.propTypes = { value: PropTypes.number }; and (2) a static PropertyDefinition keyed 'propTypes' inside a ClassBody whose class (ClassDeclaration/ClassExpression id, or the VariableDeclarator id binding a ClassExpression) is uppercase-named, e.g. class Component { static propTypes = {...} }. The uppercase-receiver heuristic deliberately excludes lowercase objects, so config.propTypes = {...} or options.propTypes is never flagged: suppress those as well as any non-component object that happens to expose a propTypes field. The rule is version-gated upstream in the oxlint plugin source (requires react:19), so a flagged finding is already on a React 19+ project; still suppress if you can establish the code is genuinely pre-React-19, where propTypes still runs.
Constraints:
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears from changed code.
- Run an unfiltered scan of the affected scope before claiming no cross-category regression.
- Report the files changed and any checks you could not run.