`react-doctor/no-predicate-function-reference-in-boolean-position`

Predicate function used without calling it

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: always
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/no-predicate-function-reference-in-boolean-position. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

function shouldContinue() {
  return false;
}
while (shouldContinue) {
  step();
}

Corrected pattern

function shouldContinue() {
  return false;
}
while (shouldContinue()) {
  step();
}

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/no-predicate-function-reference-in-boolean-position diagnostic in the current repository. Required change: - A bare is*/has*/can*/should*/will* function reference is always truthy in a condition, so the guarded branch never behaves as intended. Call the function (isReady()) to evaluate the predicate.

Reference transformation:Before:

function shouldContinue() {
  return false;
}
while (shouldContinue) {
  step();
}

After:

function shouldContinue() {
  return false;
}
while (shouldContinue()) {
  step();
}

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/no-prevent-default: Use `<form action={serverAction}>` (works without JS) or `<button>` instead of `<a>` with preventDefault
react-doctor/no-promise-then-side-effect-in-effect-without-catch: Effect promise .then sets state with no catch
react-doctor/no-prop-callback-in-effect: Lift the shared state into a Provider so both sides read the same source — no useEffect-driven sync needed
react-doctor/no-prop-callback-in-render: Prop callback invoked during render
react-doctor/no-random-key: Replace the fresh-each-render key with a stable id from the item: key={item.id}

react-doctor/no-predicate-function-reference-in-boolean-position