react-doctor/no-pass-data-to-parent
Disallow passing data to parents in an effect.
- Status
- Active
- Category
- Bugs
- Assessment
- Evidence-required risk
- Required evidence
- source code
- Default configuration
- Enabled
- Default severity
- warn
Show technical metadata
- Scope
- All supported frameworks
- Active when
- React projects
- Requirements
- react
- Tags
- test-noise
- Priority
- 36 (P3)
- Source
- oxlint-plugin-react-doctor
- Rule set
- oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
- Documentation
- Official documentation
Validation prompt
Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.
Fires when a cleanup-less useEffect synchronously calls a parent callback with data the child produced. Callback provenance survives exact aliases and transparent React wrappers such as useEffectEvent(onChange) and useCallback(onChange, [onChange]); wrapping the callback does not change data ownership. Suppress when the child owns an external subscription, such as matchMedia, a resize observer, or a WebSocket, that the parent cannot subscribe to.
Evidence boundary
The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.
Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.
Record one outcome:
- Confirmed failure: The required evidence establishes the violation.
- Rejected: A documented exception or false-positive predicate applies.
- Needs evidence: Named evidence can still be collected.
- Unavailable: Required evidence cannot be collected in this run.
- Waived with evidence: An authorized, scoped exception applies to an established failure.
- Observation: The review records an optional tradeoff without claiming a defect.
A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.
Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.
Fix prompt
Apply this candidate correction only after the required evidence confirms the risk.
Move data acquisition to the parent and pass the result down through props. If the logic must stay reusable, return the value from a custom hook that the parent calls. Do not wrap the parent callback to hide the same upward data flow. See https://react.dev/learn/you-might-not-need-an-effect#passing-data-to-the-parent
Repository-wide copy prompt
Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.
Show repository-wide prompt
Fix every confirmed react-doctor/no-pass-data-to-parent diagnostic in the current repository.
Required change:
- Move data acquisition to the parent and pass the result down through props. If the logic must stay reusable, return the value from a custom hook that the parent calls. Do not wrap the parent callback to hide the same upward data flow. See https://react.dev/learn/you-might-not-need-an-effect#passing-data-to-the-parent.
Validation before editing:
Fires when a cleanup-less useEffect synchronously calls a parent callback with data the child produced. Callback provenance survives exact aliases and transparent React wrappers such as useEffectEvent(onChange) and useCallback(onChange, [onChange]); wrapping the callback does not change data ownership. Suppress when the child owns an external subscription, such as matchMedia, a resize observer, or a WebSocket, that the parent cannot subscribe to.
Constraints:
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project:
React projects.
Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears from changed code.
- Run an unfiltered scan of the affected scope before claiming no cross-category regression.
- Report the files changed and any checks you could not run.