react-doctor/no-mutate-queried-dom-node-in-component
Mutating a queried DOM node this component renders
- Category: Bugs
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: always
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/no-mutate-queried-dom-node-in-component. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
import { useEffect as useBrowserEffect } from "react";
function Row({ opacity, useBrowserEffect }) {
useBrowserEffect(() => {
return () => {
const row = document.getElementById("row");
row.style.opacity = "";
};
});
return <div id="row" style={{ opacity }} />;
}Corrected pattern
function Row({ opacity }) {
return <div id="row" style={{ opacity }} />;
}How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/no-mutate-queried-dom-node-in-component diagnostic in the current repository.
Required change:
- Drive the node with state/props (or a ref for genuinely uncontrolled nodes) instead of querying it and mutating its style/class. Imperative edits to a node React renders are invisible to the virtual DOM and get reverted or clobbered on the next render.import { useEffect as useBrowserEffect } from "react";
function Row({ opacity, useBrowserEffect }) {
useBrowserEffect(() => {
return () => {
const row = document.getElementById("row");
row.style.opacity = "";
};
});
return <div id="row" style={{ opacity }} />;
}function Row({ opacity }) {
return <div id="row" style={{ opacity }} />;
}Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.
Related rules
More Bugs rules from the rules reference:
react-doctor/no-mutate-then-set-or-return-same-reference: State mutated in place then set by same referencereact-doctor/no-mutating-array-method-on-prop-or-hook-result: In-place array mutation on a prop or hook resultreact-doctor/no-mutating-reducer-state: Return a new reducer state object/array/collection instead of mutating the current state and returning the same top-level reference.react-doctor/no-namespace: Drop the namespace and use a plain (Pascal-cased) component or DOM tag.react-doctor/no-nested-component-definition: Move to a separate file or to module scope above the parent component