`react-doctor/no-loading-flag-reset-outside-finally`

Loading flag reset outside finally

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: react
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/no-loading-flag-reset-outside-finally. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

const saveChanges = async () => {
  setLoading(true);
  await save();
  setLoading(false);
};

Corrected pattern

const saveChanges = async () => {
  setLoading(true);
  try {
    await save();
  } finally {
    setLoading(false);
  }
};

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/no-loading-flag-reset-outside-finally diagnostic in the current repository. Required change: - Reset the loading flag in finally so success and failure both clear it. A reset after await does not run when the request rejects.

Reference transformation:Before:

const saveChanges = async () => {
  setLoading(true);
  await save();
  setLoading(false);
};

After:

const saveChanges = async () => {
  setLoading(true);
  try {
    await save();
  } finally {
    setLoading(false);
  }
};

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: react. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/no-locale-format-in-render: Locale/timezone formatting during render
react-doctor/no-match-media-in-state-initializer: matchMedia in state initializer
react-doctor/no-mirror-prop-effect: Delete both the `useState` and the `useEffect` and read the prop directly during render. Mirroring a prop into local state forces a stale first render before the effect re-syncs
react-doctor/no-mixed-srcset-descriptors: srcSet mixes width and density descriptors
react-doctor/no-mutable-in-deps: Read mutable values (`location.pathname`, `ref.current`) inside the effect body instead of in the deps array, or subscribe with `useSyncExternalStore`. Mutations to these don't trigger re-renders, so listing them in deps doesn't make the effect react to changes

react-doctor/no-loading-flag-reset-outside-finally