`react-doctor/no-inline-hoc-on-component`

Function component defined inline inside an HOC call

Category: Maintainability
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: always
Tags: test-noise, react-jsx-only
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/no-inline-hoc-on-component. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

const Header = withTracking((props) => {
  const [open, setOpen] = useState(false);
  return <h1 onClick={() => setOpen(!open)}>{props.title}</h1>;
});

Corrected pattern

const HeaderView = (props) => {
  const [open, setOpen] = useState(false);
  return <h1 onClick={() => setOpen(!open)}>{props.title}</h1>;
};
const Header = withTracking(HeaderView);

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/no-inline-hoc-on-component diagnostic in the current repository. Required change: - Extract the inline function into a named base component at module scope and pass the reference to the HOC (const CardBase = (props) => ...; const Card = withTracking(CardBase);). This restores rules-of-hooks and exhaustive-deps analysis and gives the component a stable display name.

Reference transformation:Before:

const Header = withTracking((props) => {
  const [open, setOpen] = useState(false);
  return <h1 onClick={() => setOpen(!open)}>{props.title}</h1>;
});

After:

const HeaderView = (props) => {
  const [open, setOpen] = useState(false);
  return <h1 onClick={() => setOpen(!open)}>{props.title}</h1>;
};
const Header = withTracking(HeaderView);

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Maintainability rules from the rules reference:

react-doctor/no-italic-serif-display-heading: Display heading combines italic serif styling
react-doctor/no-layout-shifting-interaction-state: Interaction state changes layout geometry
react-doctor/no-manufactured-contrast-copy: Page repeatedly uses manufactured contrast copy
react-doctor/no-many-boolean-props: Split into compound components or named variants: `<Button.Primary />`, `<DialogConfirm />` instead of stacking `isPrimary`, `isConfirm` flags
react-doctor/no-mixed-animation-owners: CSS and Motion animate the same property

react-doctor/no-inline-hoc-on-component