`react-doctor/no-enter-submit-without-ime-composition-guard`

Enter submit without IME composition guard

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: i18n
Tags: react-jsx-only
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/no-enter-submit-without-ime-composition-guard. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

const Field = ({ isComposing, onSave }) => {
  const commitEdit = () => {
    onSave();
    if (isComposing) return;
  };
  return (
    <input
      onKeyDown={(event) => {
        if (event.key === "Enter") commitEdit();
      }}
    />
  );
};

Corrected pattern

const Field = ({ onSave }) => {
  const commitEdit = () => {
    onSave();
  };
  return (
    <input
      onKeyDown={(event) => {
        if (event.key === "Enter" && !event.nativeEvent.isComposing) {
          commitEdit();
        }
      }}
    />
  );
};

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/no-enter-submit-without-ime-composition-guard diagnostic in the current repository. Required change: - Bail on IME composition before acting on Enter: if (e.nativeEvent.isComposing) return; (or track composition with onCompositionStart/onCompositionEnd). Otherwise Enter fires mid-composition and commits a half-typed value for CJK users.

Reference transformation:Before:

const Field = ({ isComposing, onSave }) => {
  const commitEdit = () => {
    onSave();
    if (isComposing) return;
  };
  return (
    <input
      onKeyDown={(event) => {
        if (event.key === "Enter") commitEdit();
      }}
    />
  );
};

After:

const Field = ({ onSave }) => {
  const commitEdit = () => {
    onSave();
  };
  return (
    <input
      onKeyDown={(event) => {
        if (event.key === "Enter" && !event.nativeEvent.isComposing) {
          commitEdit();
        }
      }}
    />
  );
};

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: i18n. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/no-event-handler: Disallow using state and an effect as an event handler.
react-doctor/no-event-trigger-state: Delete the trigger state (`useState(null)` plus the `useEffect` that watches it) and call the side-effect (`post(...)` / `navigate(...)` / `track(...)`) directly inside the event handler that previously called the setter. State should not exist purely to schedule effect runs
react-doctor/no-fetch-in-effect: Use `useQuery()` from @tanstack/react-query, `useSWR()`, or fetch in a Server Component instead
react-doctor/no-fetch-response-used-without-status-check: fetch Response consumed without status check
react-doctor/no-fill-map-element-as-key: fill().map() first param is the element, not the index

react-doctor/no-enter-submit-without-ime-composition-guard