react-doctor/no-deprecated-keyboard-event-keycode-which
Deprecated KeyboardEvent keyCode or which
- Category: Bugs
- Severity: warn
- Source:
oxlint-plugin-react-doctor - Framework: global
- Enabled when: always
- Default: Enabled
Validate the diagnostic
Confirm the reported code matches this rule before you edit it.
Confirm the reported code matches react-doctor/no-deprecated-keyboard-event-keycode-which. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.
Compare the code
The corrected pattern shows a focused way to address the diagnostic.
Reported pattern
const onKeyDown = (event: KeyboardEvent) => {
analytics({ key: event.key });
if (event.keyCode === 65) selectAll();
};Corrected pattern
const onKeyDown = (event: KeyboardEvent) => {
analytics({ key: event.key });
if (event.code === "KeyA") selectAll();
};How to fix
Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.
Copyable fix prompt
Copy this self-contained prompt into your coding agent after you confirm the diagnostic.
Fix every confirmed
Reference transformation:Before:react-doctor/no-deprecated-keyboard-event-keycode-which diagnostic in the current repository.
Required change:
- KeyboardEvent.keyCode/which/charCode are deprecated and layout/engine dependent for character keys. Branch on event.key (logical key like '/') or event.code (physical position) so the handler works across keyboard layouts and browsers.const onKeyDown = (event: KeyboardEvent) => {
analytics({ key: event.key });
if (event.keyCode === 65) selectAll();
};const onKeyDown = (event: KeyboardEvent) => {
analytics({ key: event.key });
if (event.code === "KeyA") selectAll();
};Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.
Related rules
More Bugs rules from the rules reference:
react-doctor/no-derived-state: Disallow storing derived state in an effect.react-doctor/no-derived-state-effect: For derived state, compute inline: `const x = fn(dep)`. For state resets on prop change, use a key prop: `<Component key={prop} />`. See https://react.dev/learn/you-might-not-need-an-effectreact-doctor/no-derived-useState: Remove useState and compute the value inline: `const value = transform(propName)`react-doctor/no-did-mount-set-state: Derive state in getDerivedStateFromProps or initial state instead of calling this.setState in componentDidMount, which forces an extra render.react-doctor/no-did-update-set-state: Avoid calling this.setState in componentDidUpdate; derive the value with getDerivedStateFromProps to prevent re-render loops