`react-doctor/no-collapse-request-error-to-empty-state`

Request failure rendered as an empty result

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: react
Tags: react-jsx-only
Default: Disabled until configured

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/no-collapse-request-error-to-empty-state. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

import { useState } from "react";
const Search = () => {
  const [items, setItems] = useState([]);
  const load = async () => {
    try {
      const response = await fetch("/api/items");
      setItems(await response.json());
    } catch {
      setItems([]);
    }
  };
  if (!items.length) return <p>No results found</p>;
  return <ResultList items={items} />;
};

Corrected pattern

import { useState } from "react";
const Search = () => {
  const [items, setItems] = useState([]);
  const [error, setError] = useState(null);
  const load = async () => {
    try {
      const response = await fetch("/api/items");
      setItems(await response.json());
    } catch (requestError) {
      setError(requestError);
    }
  };
  if (error) return <p role="alert">Could not load results.</p>;
  if (!items.length) return <p>No results found</p>;
  return <ResultList items={items} />;
};

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/no-collapse-request-error-to-empty-state diagnostic in the current repository. Required change: - Represent request failure separately from an empty success. Keep prior results visible when appropriate, and provide retry.

Reference transformation:Before:

import { useState } from "react";
const Search = () => {
  const [items, setItems] = useState([]);
  const load = async () => {
    try {
      const response = await fetch("/api/items");
      setItems(await response.json());
    } catch {
      setItems([]);
    }
  };
  if (!items.length) return <p>No results found</p>;
  return <ResultList items={items} />;
};

After:

import { useState } from "react";
const Search = () => {
  const [items, setItems] = useState([]);
  const [error, setError] = useState(null);
  const load = async () => {
    try {
      const response = await fetch("/api/items");
      setItems(await response.json());
    } catch (requestError) {
      setError(requestError);
    }
  };
  if (error) return <p role="alert">Could not load results.</p>;
  if (!items.length) return <p>No results found</p>;
  return <ResultList items={items} />;
};

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: react. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/no-collapsed-literal-or-chain-as-value: All-literal logical chain used as a multi-value expression
react-doctor/no-conflicting-spring-options: Motion spring mixes incompatible option modes
react-doctor/no-controlled-input-value-without-state-update: Controlled input value is a fixed literal
react-doctor/no-create-context-in-render: Move createContext to module scope so its Context identity stays stable across renders
react-doctor/no-create-object-url-in-render: Object URL is created during render

react-doctor/no-collapse-request-error-to-empty-state