New
Introducing React Bench, see how different models perform on React code

react-doctor/no-children-prop

Disallow passing children as an explicit prop: nest content between the opening and closing tags instead.

Status
Active
Category
Correctness
Assessment
Evidence-required risk
Required evidence
source code
Default configuration
Enabled
Default severity
warn
Show technical metadata
Scope
All supported frameworks
Active when
always (unless customRulesOnly=true)
Requirements
react
Priority
24 (P3)
Source
oxlint-plugin-react-doctor
Rule set
oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
On this page

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires when children is passed as an explicit JSX attribute (<Wrapper children={<Inner />} />) or as a key inside React.createElement's props object. Both forms are equivalent to nested JSX but less idiomatic.

Suppress when: legacy render-prop APIs like React Router 5's <Route children={(routeProps) => ...}> or Apollo's <Query children={({ data }) => ...}> deliberately pass a function via the children attribute.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

  • Confirmed failure: The required evidence establishes the violation.
  • Rejected: A documented exception or false-positive predicate applies.
  • Needs evidence: Named evidence can still be collected.
  • Unavailable: Required evidence cannot be collected in this run.
  • Waived with evidence: An authorized, scoped exception applies to an established failure.
  • Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Move the value between the opening and closing tags: <Wrapper><Inner /></Wrapper>, or pass siblings (<Wrapper><Header /><Body /></Wrapper>). For React.createElement, pass children as positional arguments: createElement("div", {}, "Hi") or createElement("ul", {}, item1, item2). See https://oxc.rs/docs/guide/usage/linter/rules/react/no-children-prop.html and https://react.dev/learn/passing-props-to-a-component#passing-jsx-as-children

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.

Show repository-wide prompt

Fix every confirmed react-doctor/no-children-prop diagnostic in the current repository.

Required change:

Validation before editing:

Fires when children is passed as an explicit JSX attribute (<Wrapper children={<Inner />} />) or as a key inside React.createElement's props object. Both forms are equivalent to nested JSX but less idiomatic.

Suppress when: legacy render-prop APIs like React Router 5's <Route children={(routeProps) => ...}> or Apollo's <Query children={({ data }) => ...}> deliberately pass a function via the children attribute.

Constraints:

  • Make the smallest change that fixes the root cause.
  • Preserve behavior and interfaces unrelated to this diagnostic.
  • Reuse existing project components, utilities, and conventions.
  • Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
  • Adapt identifiers and framework details instead of copying blindly.
  • Do not disable the rule or suppress matching code.
  • Confirm this rule is enabled for the project: always (unless customRulesOnly=true).

Assessment:

  • Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
  • Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
  • A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

Verification:

  • Run focused tests for the changed behavior.
  • Run React Doctor and confirm this diagnostic no longer appears from changed code.
  • Run an unfiltered scan of the affected scope before claiming no cross-category regression.
  • Report the files changed and any checks you could not run.