New
Introducing React Bench, see how different models perform on React code

react-doctor/jsx-props-no-spreading

List each prop explicitly so consumers can see what's being passed instead of spreading.

Status
Active
Category
Architecture
Assessment
Evidence-required risk
Required evidence
source code, repository context
Default configuration
Disabled until configured
Default severity
warn
Show technical metadata
Scope
All supported frameworks
Active when
off by default (opt-in)
Requirements
react
Priority
20 (P3)
Source
oxlint-plugin-react-doctor
Rule set
oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
On this page

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires on any JSX spread attribute: <C {...props} />: across intrinsic HTML tags, capitalized components, and member-expression names (Nav.Item); settings can scope it to html-only or custom-only, exempt specific tags, or (with explicitSpread:"ignore") allow object-literal spreads like <Foo {...{ a, b }} /> unless they contain a nested spread ({...{ ...rest }} still fires).

Suppress when: {...props} is the canonical composition pattern: forwardRef wrappers, shadcn-ui / Radix / Headless UI consumers, and polymorphic components legitimately forward an open-ended prop bag, so an enabled finding here is often intentional pass-through, not a defect.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

  • Confirmed failure: The required evidence establishes the violation.
  • Rejected: A documented exception or false-positive predicate applies.
  • Needs evidence: Named evidence can still be collected.
  • Unavailable: Required evidence cannot be collected in this run.
  • Waived with evidence: An authorized, scoped exception applies to an established failure.
  • Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Replace the spread with an explicit prop list so the JSX shows exactly what's passed: <Avatar src={user.avatar} alt={user.name} size="lg" /> instead of <Avatar {...user} />. When forwarding is genuinely intended (wrappers, polymorphic as components, design-system primitives), this is idiomatic: either leave the rule off for that boundary or add a per-tag entry to the exceptions setting rather than rewriting it. See https://oxc.rs/docs/guide/usage/linter/rules/react/jsx-props-no-spreading

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.

Show repository-wide prompt

Fix every confirmed react-doctor/jsx-props-no-spreading diagnostic in the current repository.

Required change:

  • Replace the spread with an explicit prop list so the JSX shows exactly what's passed: <Avatar src={user.avatar} alt={user.name} size="lg" /> instead of <Avatar {...user} />. When forwarding is genuinely intended (wrappers, polymorphic as components, design-system primitives), this is idiomatic: either leave the rule off for that boundary or add a per-tag entry to the exceptions setting rather than rewriting it. See https://oxc.rs/docs/guide/usage/linter/rules/react/jsx-props-no-spreading.

Validation before editing:

Fires on any JSX spread attribute: <C {...props} />: across intrinsic HTML tags, capitalized components, and member-expression names (Nav.Item); settings can scope it to html-only or custom-only, exempt specific tags, or (with explicitSpread:"ignore") allow object-literal spreads like <Foo {...{ a, b }} /> unless they contain a nested spread ({...{ ...rest }} still fires).

Suppress when: {...props} is the canonical composition pattern: forwardRef wrappers, shadcn-ui / Radix / Headless UI consumers, and polymorphic components legitimately forward an open-ended prop bag, so an enabled finding here is often intentional pass-through, not a defect.

Constraints:

  • Make the smallest change that fixes the root cause.
  • Preserve behavior and interfaces unrelated to this diagnostic.
  • Reuse existing project components, utilities, and conventions.
  • Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
  • Adapt identifiers and framework details instead of copying blindly.
  • Do not disable the rule or suppress matching code.
  • Confirm this rule is enabled for the project: off by default (opt-in).

Assessment:

  • Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
  • Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
  • A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

Verification:

  • Run focused tests for the changed behavior.
  • Run React Doctor and confirm this diagnostic no longer appears from changed code.
  • Run an unfiltered scan of the affected scope before claiming no cross-category regression.
  • Report the files changed and any checks you could not run.