react-doctor/jsx-no-new-function-as-prop
Memoize the callback (useCallback) or hoist it outside the component to keep a stable reference across renders.
- Status
- Active
- Category
- Performance
- Assessment
- Evidence-required risk
- Required evidence
- source code, runtime behavior, measurement
- Default configuration
- Enabled
- Default severity
- warn
Show technical metadata
- Scope
- All supported frameworks
- Active when
- always
- Disabled when
- react-compiler
- Requirements
- react
- Tags
- react-jsx-only
- Priority
- 42 (P3)
- Source
- oxlint-plugin-react-doctor
- Rule set
- oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
- Documentation
- Official documentation
Validation prompt
Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.
Fires when a JSX prop on a custom component receives a freshly-allocated function each render: an inline arrow/function expression, new Function/Function(), a .bind() call, a logical/ternary that produces one, or a render-local identifier bound to such: but ONLY when same-file analysis PROVES the consumer is wrapped in React.memo/memo/forwardRef/observer. Intrinsic HTML elements, one-shot lifecycle/render-prop names (onMount, fallback, render*, *Renderer), parameter-binding wrappers like (e) => fn(arg, e), hook-returned handlers (const h = useFoo()), and test files are all skipped by design.
Suppress when: a wrapper the rule misclassified as fixable when it actually closes over unstable outer values: useCallback can't stabilize it, so the only "fix" would be a data-flow refactor with no measurable gain unless the consumer is truly memoised. Also note the whole rule is disabled under react-compiler, which auto-memoizes inline callbacks.
Evidence boundary
The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.
Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.
Record one outcome:
- Confirmed failure: The required evidence establishes the violation.
- Rejected: A documented exception or false-positive predicate applies.
- Needs evidence: Named evidence can still be collected.
- Unavailable: Required evidence cannot be collected in this run.
- Waived with evidence: An authorized, scoped exception applies to an established failure.
- Observation: The review records an optional tradeoff without claiming a defect.
A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.
Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.
Fix prompt
Apply this candidate correction only after the required evidence confirms the risk.
Give the prop a stable reference: wrap the handler in useCallback(fn, [deps]), or hoist a closure-free function above the component (const handleClick = () => {...} at module scope). When the wrapper must capture per-render args (onClick={(e) => fn(id, e)}), pass the data down instead (<Child id={id} onClick={fn} />) rather than forcing a callback. Only worth doing because the consumer here is memoised, so a fresh reference defeats its memo bailout. See https://oxc.rs/docs/guide/usage/linter/rules/react_perf/jsx-no-new-function-as-prop
Repository-wide copy prompt
Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.
Show repository-wide prompt
Fix every confirmed react-doctor/jsx-no-new-function-as-prop diagnostic in the current repository.
Required change:
- Give the prop a stable reference: wrap the handler in
useCallback(fn, [deps]), or hoist a closure-free function above the component (const handleClick = () => {...}at module scope). When the wrapper must capture per-render args (onClick={(e) => fn(id, e)}), pass the data down instead (<Child id={id} onClick={fn} />) rather than forcing a callback. Only worth doing because the consumer here is memoised, so a fresh reference defeats its memo bailout. See https://oxc.rs/docs/guide/usage/linter/rules/react_perf/jsx-no-new-function-as-prop.
Validation before editing:
Fires when a JSX prop on a custom component receives a freshly-allocated function each render: an inline arrow/function expression, new Function/Function(), a .bind() call, a logical/ternary that produces one, or a render-local identifier bound to such: but ONLY when same-file analysis PROVES the consumer is wrapped in React.memo/memo/forwardRef/observer. Intrinsic HTML elements, one-shot lifecycle/render-prop names (onMount, fallback, render*, *Renderer), parameter-binding wrappers like (e) => fn(arg, e), hook-returned handlers (const h = useFoo()), and test files are all skipped by design.
Suppress when: a wrapper the rule misclassified as fixable when it actually closes over unstable outer values: useCallback can't stabilize it, so the only "fix" would be a data-flow refactor with no measurable gain unless the consumer is truly memoised. Also note the whole rule is disabled under react-compiler, which auto-memoizes inline callbacks.
Constraints:
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path.
- If syntax proves only a candidate cost, require a relevant trace, bundle report, payload measurement, or metric before editing.
- Without evidence, record Needs evidence. Compare the same scenario before and after; keep the change only when its target metric improves without regression.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Do not edit code when this condition applies: react-compiler.
Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears from changed code.
- Run an unfiltered scan of the affected scope before claiming no cross-category regression.
- Report the files changed and any checks you could not run.