New
Introducing React Bench, see how different models perform on React code

react-doctor/jsx-no-new-array-as-prop

Memoize the array (useMemo) or hoist it outside the component instead of allocating a new one each render.

Status
Active
Category
Performance
Assessment
Evidence-required risk
Required evidence
source code, runtime behavior, measurement
Default configuration
Enabled
Default severity
warn
Show technical metadata
Scope
All supported frameworks
Active when
always
Disabled when
react-compiler
Requirements
react
Tags
react-jsx-only
Priority
40 (P3)
Source
oxlint-plugin-react-doctor
Rule set
oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
On this page

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires on a JSX prop whose value freshly allocates an array every render: an array literal [], new Array()/Array(), arr.concat(...), single-arg arr.map(fn)/arr.filter(fn), or those wrapped in a ternary or ??/|| logical, or a render-local identifier bound to one of those. A ternary fires when EITHER branch produces an array (so cond ? value : [] fires because the [] alternate counts as array-producing), whereas a ??/|| with an empty-array literal on one side treats that side as a skipped fallback and only checks the other. It only fires when the consumer component is PROVEN memoised in the same file, the prop is NOT a data-collection slot (items/data/list/options/tabs/*Items/*Options, etc.), and the element is a custom component (not an intrinsic HTML tag) outside test files.

Suppress when: an empty-array fallback in a logical short-circuit (value ?? [] or value || []) where the other side is non-array-producing: the [] only allocates on the rare null/undefined path, so it isn't a per-render footgun. This exemption does NOT extend to ternaries: cond ? value : [] still fires because the [] branch is treated as array-producing.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

  • Confirmed failure: The required evidence establishes the violation.
  • Rejected: A documented exception or false-positive predicate applies.
  • Needs evidence: Named evidence can still be collected.
  • Unavailable: Required evidence cannot be collected in this run.
  • Waived with evidence: An authorized, scoped exception applies to an established failure.
  • Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Hoist a truly constant array to module scope (const EMPTY: Item[] = []) so its identity never changes, or memoize a derived one: const rows = useMemo(() => items.map(toRow), [items]) and pass list={rows}. For .concat/.filter/.map chains, compute them inside a useMemo keyed on their inputs rather than inline in JSX, keeping the prop a stable reference across renders. If the warning is on a ternary like cond ? value : [], pull the empty fallback out so it isn't reallocated each render: e.g. const EMPTY: Item[] = [] at module scope, then list={cond ? value : EMPTY}. See https://oxc.rs/docs/guide/usage/linter/rules/react_perf/jsx-no-new-array-as-prop

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.

Show repository-wide prompt

Fix every confirmed react-doctor/jsx-no-new-array-as-prop diagnostic in the current repository.

Required change:

  • Hoist a truly constant array to module scope (const EMPTY: Item[] = []) so its identity never changes, or memoize a derived one: const rows = useMemo(() => items.map(toRow), [items]) and pass list={rows}. For .concat/.filter/.map chains, compute them inside a useMemo keyed on their inputs rather than inline in JSX, keeping the prop a stable reference across renders. If the warning is on a ternary like cond ? value : [], pull the empty fallback out so it isn't reallocated each render: e.g. const EMPTY: Item[] = [] at module scope, then list={cond ? value : EMPTY}. See https://oxc.rs/docs/guide/usage/linter/rules/react_perf/jsx-no-new-array-as-prop.

Validation before editing:

Fires on a JSX prop whose value freshly allocates an array every render: an array literal [], new Array()/Array(), arr.concat(...), single-arg arr.map(fn)/arr.filter(fn), or those wrapped in a ternary or ??/|| logical, or a render-local identifier bound to one of those. A ternary fires when EITHER branch produces an array (so cond ? value : [] fires because the [] alternate counts as array-producing), whereas a ??/|| with an empty-array literal on one side treats that side as a skipped fallback and only checks the other. It only fires when the consumer component is PROVEN memoised in the same file, the prop is NOT a data-collection slot (items/data/list/options/tabs/*Items/*Options, etc.), and the element is a custom component (not an intrinsic HTML tag) outside test files.

Suppress when: an empty-array fallback in a logical short-circuit (value ?? [] or value || []) where the other side is non-array-producing: the [] only allocates on the rare null/undefined path, so it isn't a per-render footgun. This exemption does NOT extend to ternaries: cond ? value : [] still fires because the [] branch is treated as array-producing.

Constraints:

  • Make the smallest change that fixes the root cause.
  • Preserve behavior and interfaces unrelated to this diagnostic.
  • Reuse existing project components, utilities, and conventions.
  • Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
  • Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path.
  • If syntax proves only a candidate cost, require a relevant trace, bundle report, payload measurement, or metric before editing.
  • Without evidence, record Needs evidence. Compare the same scenario before and after; keep the change only when its target metric improves without regression.
  • Adapt identifiers and framework details instead of copying blindly.
  • Do not disable the rule or suppress matching code.
  • Do not edit code when this condition applies: react-compiler.

Assessment:

  • Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
  • Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
  • A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

Verification:

  • Run focused tests for the changed behavior.
  • Run React Doctor and confirm this diagnostic no longer appears from changed code.
  • Run an unfiltered scan of the affected scope before claiming no cross-category regression.
  • Report the files changed and any checks you could not run.