react-doctor/firebase-query-filter-as-auth

Relying on a client-side Firestore `.where('userId', '==', …)` filter for access control is unsafe, because a client can drop the filter and read everyone's data.

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires when client code calls .where('<field>', '==', …) where <field> is an auth-shaped key: uid, userId/userID, ownerId/ownerID, orgId/orgID, tenantId/tenantID, or role: i.e. a Firestore query that scopes results by identity/tenant/role. The concern: a client query filter is not an access-control boundary, since a client can issue the same query without it.

Suppress when: the matching .where(...) is only UX/data-scoping AND the project's Firestore security rules already enforce the same request.auth.uid/membership check server-side: then the filter is defense-in-depth, not the sole gate. Only the literal == operator on a literal field-name string is matched.

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

• Confirmed failure: The required evidence establishes the violation.
• Rejected: A documented exception or false-positive predicate applies.
• Needs evidence: Named evidence can still be collected.
• Unavailable: Required evidence cannot be collected in this run.
• Waived with evidence: An authorized, scoped exception applies to an established failure.
• Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

Treat the client .where(...) as convenience only and enforce access in firestore.rules: inside the match block require request.auth != null and compare the document against request.auth.uid (or a trusted memberships/roles collection via get()), so reads and writes are denied regardless of the query. Keep the filter for scoping, never for security.

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.