react-doctor/design-no-em-dash-in-jsx-text
Replace em dashes in JSX prose with commas, colons, semicolons, or parentheses so UI copy reads less like generated text.
- Status
- Active
- Category
- Architecture
- Assessment
- Creative-direction review
- Required evidence
- source code, repository context, rendered UI, product intent
- Default configuration
- Disabled until configured
- Default severity
- warn
Show technical metadata
- Scope
- All supported frameworks
- Active when
- always
- Requirements
- react
- Tags
- design, test-noise
- Priority
- 16 (P3)
- Source
- oxlint-plugin-react-doctor
- Rule set
- oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
Creative-direction review: This rule is explicitly classified as a preference. Review it against the product brief, rendered context, brand system, and user needs. Keeping an intentional choice with evidence is a successful outcome.
Validation prompt
Review the reported pattern in context before deciding whether an edit is warranted.
Fires when a JSXText node literally contains the em-dash character: (U+2014). The rule walks up the ancestor chain and skips text inside <code>, <pre>, <kbd>, <samp>, <var>, <tt>, or any element with translate="no". Dynamic strings inside {expression} containers aren't inspected, so interpolated copy escapes the check.
Evidence boundary
The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.
Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.
The design tag controls activation and discovery. It does not determine the rule’s proof class.
Record one outcome:
- Confirmed failure: The required evidence establishes the violation.
- Rejected: A documented exception or false-positive predicate applies.
- Needs evidence: Named evidence can still be collected.
- Unavailable: Required evidence cannot be collected in this run.
- Waived with evidence: An authorized, scoped exception applies to an established failure.
- Observation: The review records an optional tradeoff without claiming a defect.
A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.
Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.
Fix prompt
Treat this as review guidance, not a required correction. Preserve an intentional choice when the brief, design system, and rendered evidence support it.
Replace: with a comma, colon, semicolon, parentheses, or a plain hyphen for ranges. Em dashes scream LLM output in product copy; tightening the sentence almost always improves it. Reserve em dashes for long-form editorial content where you've audited the voice. https://practicaltypography.com/hyphens-and-dashes.html
Repository-wide copy prompt
Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.
Show repository-wide prompt
Review every confirmed react-doctor/design-no-em-dash-in-jsx-text diagnostic in the current repository.
Revise only when evidence supports the candidate adjustment.
- Replace: with a comma, colon, semicolon, parentheses, or a plain hyphen for ranges. Em dashes scream LLM output in product copy; tightening the sentence almost always improves it. Reserve em dashes for long-form editorial content where you've audited the voice. https://practicaltypography.com/hyphens-and-dashes.html.
Validation before editing:
Fires when a JSXText node literally contains the em-dash character: (U+2014). The rule walks up the ancestor chain and skips text inside <code>, <pre>, <kbd>, <samp>, <var>, <tt>, or any element with translate="no". Dynamic strings inside {expression} containers aren't inspected, so interpolated copy escapes the check.
Constraints:
- If revising, make the smallest change that addresses the observed tradeoff.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- This rule is explicitly classified as creative-direction review. The design tag alone never determines proof class.
- Inspect the product brief, rendered context, and existing design system before editing.
- Keep an intentional pattern that is consistent with the project, and report why it stays.
- Verify accessibility and performance claims with rendered or runtime evidence.
- Use existing brand assets, product facts, content, and design tokens.
- Do not invent claims, customer data, typefaces, artwork, or a new visual direction.
- Adapt identifiers and framework details instead of copying blindly.
- Do not change code only to silence this heuristic.
Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.
Verification:
- Run focused tests for the changed behavior.
- Re-read the changed code and inspect the affected rendered state at relevant viewport, theme, input, and motion settings.
- If rendered verification is unavailable, report that limitation instead of claiming the design is fixed.
- If revised, rerun React Doctor and report whether the diagnostic remains. If kept, cite the brief, design-system, or rendered evidence.
- Report the files changed and any checks you could not run.