`react-doctor/debounce-no-cleanup`

Memoized debounce never cancelled on unmount

Category: Bugs
Severity: warn
Source: oxlint-plugin-react-doctor
Framework: global
Enabled when: react
Default: Enabled

Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches react-doctor/debounce-no-cleanup. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

Compare the code

The corrected pattern shows a focused way to address the diagnostic.

Reported pattern

import * as lodash from "lodash";
function Search({ query, other }) {
  const search = useMemo(
    () =>
      lodash["debounce"](async (value) => {
        await fetchResults(value);
      }, 250),
    [],
  );
  useEffect(() => search(query), [query, search]);
  useEffect(() => () => other[`cancel`](), [other]);
}

Corrected pattern

import * as lodash from "lodash";
function Search({ query, other }) {
  const search = useMemo(
    () =>
      lodash["debounce"](async (value) => {
        await fetchResults(value);
      }, 250),
    [],
  );
  useEffect(() => search(query), [query, search]);
  useEffect(() => () => other[`cancel`](), [other]);
  useEffect(() => () => search[`cancel`](), [search]);
}

How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

Fix every confirmed react-doctor/debounce-no-cleanup diagnostic in the current repository. Required change: - Cancel debounced or throttled callbacks during cleanup so trailing work cannot run after unmount.

Reference transformation:Before:

import * as lodash from "lodash";
function Search({ query, other }) {
  const search = useMemo(
    () =>
      lodash["debounce"](async (value) => {
        await fetchResults(value);
      }, 250),
    [],
  );
  useEffect(() => search(query), [query, search]);
  useEffect(() => () => other[`cancel`](), [other]);
}

After:

import * as lodash from "lodash";
function Search({ query, other }) {
  const search = useMemo(
    () =>
      lodash["debounce"](async (value) => {
        await fetchResults(value);
      }, 250),
    [],
  );
  useEffect(() => search(query), [query, search]);
  useEffect(() => () => other[`cancel`](), [other]);
  useEffect(() => () => search[`cancel`](), [search]);
}

Constraints: - Confirm the reported code matches the Before pattern. - Make the smallest change that fixes the root cause. - Preserve behavior and interfaces unrelated to this diagnostic. - Reuse existing project components, utilities, and conventions. - Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations. - Adapt identifiers and framework details instead of copying blindly. - Do not disable the rule or suppress matching code. - Confirm this rule is enabled for the project: react. Verification: - Run focused tests for the changed behavior. - Run React Doctor and confirm this diagnostic no longer appears. - Report the files changed and any checks you could not run.

More Bugs rules from the rules reference:

react-doctor/effect-listener-cleanup-mismatch: Effect cleanup does not match its event listener
react-doctor/effect-listener-cleanup-reference-mismatch: Effect cleanup removes the wrong listener reference
react-doctor/effect-needs-cleanup: Return a cleanup function that releases the subscription / timer: `return () => target.removeEventListener(name, handler)` for listeners, `return () => clearInterval(id)` / `clearTimeout(id)` for timers, or `return unsubscribe` if the subscribe call already returned one
react-doctor/effect-observer-needs-disconnect: Observer created in an effect never disconnected
react-doctor/effect-raf-loop-needs-cancel: requestAnimationFrame loop never cancelled

react-doctor/debounce-no-cleanup