# `react-doctor/zustand-no-fresh-selector-result`

Zustand selector returns a fresh value

- **Category:** Performance
- **Severity:** error
- **Source:** oxlint-plugin-react-doctor
- **Framework:** global
- **Enabled when:** react, zustand, zustand:5

## Validate the diagnostic

Confirm the reported code matches this rule before you edit it.

Confirm the reported code matches `react-doctor/zustand-no-fresh-selector-result`. Compare it with the Before example and verify the same API, framework, and execution context. Treat it as a false positive only when one of those conditions differs.

## Compare the code

The corrected pattern shows a focused way to address the diagnostic.

### Reported pattern

```tsx
import { create } from "zustand";

interface Todo {
  done: boolean;
}

interface TodoStore {
  todos: Todo[];
}

const useTodoStore = create<TodoStore>(() => ({ todos: [] }));
const TodoList = () => {
  const visibleTodos = useTodoStore((state) =>
    state.todos.filter((todo) => !todo.done),
  );
  return <List items={visibleTodos} />;
};
```

### Corrected pattern

```tsx
import { create } from "zustand";
import { useShallow } from "zustand/react/shallow";

interface Todo {
  done: boolean;
}

interface TodoStore {
  todos: Todo[];
}

const useTodoStore = create<TodoStore>(() => ({ todos: [] }));
const TodoList = () => {
  const visibleTodos = useTodoStore(
    useShallow((state) => state.todos.filter((todo) => !todo.done)),
  );
  return <List items={visibleTodos} />;
};
```

## How to fix

Use the corrected pattern as a reference. Preserve behavior that the rule does not require you to change.

### Copyable fix prompt

Copy this self-contained prompt into your coding agent after you confirm the diagnostic.

````text
Fix every confirmed `react-doctor/zustand-no-fresh-selector-result` diagnostic in the current repository.

Required change:
- Select a stable store field, split the selector, or wrap a collection selector with `useShallow`.

Reference transformation:

Before:
```tsx
import { create } from "zustand";

interface Todo {
  done: boolean;
}

interface TodoStore {
  todos: Todo[];
}

const useTodoStore = create<TodoStore>(() => ({ todos: [] }));
const TodoList = () => {
  const visibleTodos = useTodoStore((state) =>
    state.todos.filter((todo) => !todo.done),
  );
  return <List items={visibleTodos} />;
};
```

After:
```tsx
import { create } from "zustand";
import { useShallow } from "zustand/react/shallow";

interface Todo {
  done: boolean;
}

interface TodoStore {
  todos: Todo[];
}

const useTodoStore = create<TodoStore>(() => ({ todos: [] }));
const TodoList = () => {
  const visibleTodos = useTodoStore(
    useShallow((state) => state.todos.filter((todo) => !todo.done)),
  );
  return <List items={visibleTodos} />;
};
```

Constraints:
- Confirm the reported code matches the Before pattern.
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Preserve resource ownership and cleanup. Do not move work into a hotter render or frame path.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Confirm this rule is enabled for the project: `react, zustand, zustand:5`.

Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears.
- Report the files changed and any checks you could not run.
````