# `react-doctor/no-effect-with-fresh-deps`

Move the constructed value into the hook body and depend on its primitive inputs, or memoize it with useMemo/useCallback so its reference is stable.

- **Status:** Active
- **Category:** State & Effects
- **Assessment:** Evidence-required risk
- **Required evidence:** source code
- **Default configuration:** Enabled
- **Default severity:** error
- **Scope:** All supported frameworks
- **Active when:** always
- **Disabled when:** react-compiler
- **Requirements:** react
- **Priority:** 68 (P2)
- **Source:** oxlint-plugin-react-doctor
- **Rule set:** oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
- **Documentation:** [Official documentation](https://react.dev/reference/react/useEffect#removing-unnecessary-object-dependencies)

## Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires on a hook in HOOKS_WITH_DEPS (useEffect, useLayoutEffect, useMemo, useCallback, also via React.useEffect) whose SECOND argument is an ArrayExpression containing an element that is, or resolves to, a freshly-allocated reference: a direct ObjectExpression, ArrayExpression, Arrow/FunctionExpression, JSXElement/JSXFragment, or NewExpression at the dep site; OR an Identifier whose binding is an UNCONDITIONAL VariableDeclarator init (const/let/var name = {...}/[...]/() => …/new …) in the same component scope. Such elements break the element-wise === (Object.is) comparison so the effect/memo re-runs every render.

Suppress when: do NOT flag plain identifiers, member expressions like options.value, deps from useMemo/useCallback/useRef/useState/useReducer or any CallExpression including custom hooks (treated as opaque), bindings declared at module/Program scope (allocated once), destructuring or parameter DEFAULTS such as function List({ items = [] }) or const { config = {} } = props (the default only allocates when the source is undefined and can't be hoisted), spread elements [...arr], empty deps [], or effects with no deps array at all (running every render is intentional there).

## Evidence boundary

The diagnostic proves only that the detector's modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, explicit repository policy, relevant exceptions, and required rendered or runtime evidence before deciding the occurrence. This page’s Assessment and Required evidence fields define the review contract.

Default severity is registry metadata. Use the occurrence's JSON severity after repository configuration when ordering real findings.

Record one outcome:

- **Confirmed failure:** The required evidence establishes the violation.
- **Rejected:** A documented exception or false-positive predicate applies.
- **Needs evidence:** Named evidence can still be collected.
- **Unavailable:** Required evidence cannot be collected in this run.
- **Waived with evidence:** An authorized, scoped exception applies to an established failure.
- **Observation:** The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

## Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

The flagged dep element is reallocated every render so its === comparison always fails and the hook fires each render. If the value is only used inside the hook, delete it from the dep array and construct it inside the hook body, depending instead on its primitive inputs (e.g. useEffect(() => { const config = { a, b }; … }, [a, b])). If it must be shared, stabilize its reference with const config = useMemo(() => ({ a, b }), [a, b]) or const handler = useCallback(() => …, [deps]) and depend on that, or hoist a truly-constant value to module scope. See https://react.dev/reference/react/useEffect#removing-unnecessary-object-dependencies

## Repository-wide copy prompt

Use this only for a repository-wide pass after validating each occurrence. For one occurrence, use the occurrence-level guidance above.

````text
Fix every confirmed `react-doctor/no-effect-with-fresh-deps` diagnostic in the current repository.

Required change:
- The flagged dep element is reallocated every render so its === comparison always fails and the hook fires each render. If the value is only used inside the hook, delete it from the dep array and construct it inside the hook body, depending instead on its primitive inputs (e.g. useEffect(() => { const config = { a, b }; … }, [a, b])). If it must be shared, stabilize its reference with const config = useMemo(() => ({ a, b }), [a, b]) or const handler = useCallback(() => …, [deps]) and depend on that, or hoist a truly-constant value to module scope. See https://react.dev/reference/react/useEffect#removing-unnecessary-object-dependencies.

Validation before editing:
Fires on a hook in HOOKS_WITH_DEPS (useEffect, useLayoutEffect, useMemo, useCallback, also via React.useEffect) whose SECOND argument is an ArrayExpression containing an element that is, or resolves to, a freshly-allocated reference: a direct ObjectExpression, ArrayExpression, Arrow/FunctionExpression, JSXElement/JSXFragment, or NewExpression at the dep site; OR an Identifier whose binding is an UNCONDITIONAL VariableDeclarator init (const/let/var name = {...}/[...]/() => …/new …) in the same component scope. Such elements break the element-wise === (Object.is) comparison so the effect/memo re-runs every render.

Suppress when: do NOT flag plain identifiers, member expressions like options.value, deps from useMemo/useCallback/useRef/useState/useReducer or any CallExpression including custom hooks (treated as opaque), bindings declared at module/Program scope (allocated once), destructuring or parameter DEFAULTS such as function List({ items = [] }) or const { config = {} } = props (the default only allocates when the source is undefined and can't be hoisted), spread elements [...arr], empty deps [], or effects with no deps array at all (running every render is intentional there).

Constraints:
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
- Do not edit code when this condition applies: react-compiler.

Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.

Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears from changed code.
- Run an unfiltered scan of the affected scope before claiming no cross-category regression.
- Report the files changed and any checks you could not run.
````